Skip to content

Add version logging to upgrade/downgrade tests #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cardil wants to merge 2 commits into
base: release-1.37
Choose a base branch
from
Open

Add version logging to upgrade/downgrade tests #3971

cardil wants to merge 2 commits into from

Conversation

@cardil
Copy link
Member

@cardil cardil commented Feb 7, 2026

Problem

The upgrade tests are hard to debug. Especially the upgrade/downgrade steps do not report anything on success, so it's hard to tell if we upgraded to 1.37.1 (as expected) or maybe 1.38.0.

Solution

Added comprehensive version logging to test/upgrade/installation/serverless.go to report:

  • Target CSV and component versions at start
  • InstallPlan approval
  • CSV success state
  • Each component version upgrade/downgrade progress
  • Final completion with version confirmation

Example Output

Now when tests run, you'll see clear output like:

🔄 Starting Serverless upgrade to CSV: serverless-operator.v1.37.1 (source: serverless-operator, channel: stable)
   Target versions - Serving: 1.18.0, Eventing: 1.18.0, Kafka: 1.15.0
   Approving InstallPlan: install-abc123
✅ CSV serverless-operator.v1.37.1 is now in Succeeded state
   Waiting for KnativeServing to reach version: 1.18.0
✅ KnativeServing is now at version: 1.18.0
   Waiting for KnativeEventing to reach version: 1.18.0
✅ KnativeEventing is now at version: 1.18.0
   Waiting for KnativeKafka to reach version: 1.15.0
✅ KnativeKafka is now at version: 1.15.0
✅ Serverless upgrade completed successfully to CSV: serverless-operator.v1.37.1

This makes it immediately clear whether the upgrade went to the expected version or an unexpected one.

Assisted-by: 🤖 Claude Opus/Sonnet 4.5

@cardil
Add version logging to upgrade/downgrade tests
b4dc475 
The upgrade tests were hard to debug because upgrade/downgrade steps
did not report version information on success. Added comprehensive
logging to report:
- Target CSV and component versions at start
- InstallPlan approval
- CSV success state
- Each component version upgrade/downgrade progress
- Final completion with version confirmation

This makes it immediately clear whether tests upgraded to the expected
version (e.g., 1.37.1) or an unexpected one (e.g., 1.38.0).

Assisted-by: 🤖 Claude Opus/Sonnet 4.5
@openshift-ci openshift-ci bot requested review from aliok and dsimansk February 7, 2026 00:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign maschmid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Member Author

cardil commented Feb 7, 2026

/cherrypick main
/cherrypick release-1.38

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Feb 7, 2026

@cardil: once the present PR merges, I will cherry-pick it on top of main, release-1.38 in new PRs and assign them to you.

Details

In response to this:

/cherrypick main
/cherrypick release-1.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented Feb 7, 2026

/retest

@cardil
Copy link
Member Author

cardil commented Feb 9, 2026

The fail (flaky) should be fixed with #3973

/hold

@cardil
Copy link
Member Author

cardil commented Feb 9, 2026

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cardil @openshift-cherrypick-robot